Open
Conversation
Updated Scheduler Open API Spec is Updated, so this file is deleted
KarolinaKopacz
suggested changes
May 17, 2023
KarolinaKopacz
left a comment
KarolinaKopacz
left a comment
There was a problem hiding this comment.
Really good job @sreepathysois !
I added some comments. They apply to all .feature files.
I also have small suggestion. Your PR is large. It is a good practice to add a smaller PR (in this case breaking this pull request into smaller ones) because it is easier and faster to check such code. It's also easier to make corrections, especially if they are repeated in other files.
KarolinaKopacz
approved these changes
Jun 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 1 of Schdeuler Test Harness with Gherkin Feature and Step_Defs Implementation Codes
Mock_Example Branch is Created to Open API Test Harness of Scheduler BB against Mock Server using BDD Approach for Testing
Description
Updated Scheduler Open API Spec File is tested using BDD Approach using Gherkin Feature File to specify Smoke, Positive/Happy Regression and Negative Unit and Regression tresting Scenarios with relevant Examples. API Testing is implemented using Mockoon-CLI as a Mock example and Pytest-BDD is used to write test implementation codes.
Changes Compared to main Branch
Feature Files for all request of Open API Endpoints and implementation Codes are Uploaded in test/Folder of mock_example Branch.
API Spec of Scheduler is updated in api/ folder.
Docker-Compose based config file to provision Mockoon Container and Test Environment is uploaded to examples/mock Folder,
Motivation and Context
Create a Version 1 Test Harness to test Scheduler API Compatability with GovStack Standards
How Has This Been Tested?
Mock Example is tested using CircleCI Config to Provision Mock Server and Generate Test Results in JSON Format and Also generate Test Summary Results.